Parry3d #118
Merged
Parry3d #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…st because it was trying to find a single point of an empty material. I've moved it out into single_ion_bca() and also made it an optional feature.
Collaborator
Author
|
I've added some tests of the cuboid and sphere - probably, at a later date, someone should do something like add a mathematically defined surface that's been turned into a triangular mesh that can be tested against; but, with these tests and the new examples, I have high confidence that the code is working is intended. I've switched the command line argument to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to rustBCA!
Before submitting this PR, please make sure you have:
Addresses #117
Description
Parry3d integration is complete. See #117 for some examples of the possible geometries now available. Geometry pipelines with pygmsh or trimesh in Python will enable some really cool BCA stuff.
Tests
Cargo test has been run. Tests of the parry3d geometry still need to be written before this is merged.